Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req [nolibs version] #245

Open
shikulja opened this issue Aug 18, 2020 · 3 comments
Open

req [nolibs version] #245

shikulja opened this issue Aug 18, 2020 · 3 comments

Comments

@shikulja
Copy link

shikulja commented Aug 18, 2020

dpsmate uses dirty versions of babblelibs for different languages, so do other libraries (GraphLib\dewdrop outdated?)
This mess is pointless when there are multi-language versions of bubblelibs.
It is also a big additional load due to the double set of libraries in game.

if not nolibs, then at least a version of dpsmate compatible with regular libraries

@shikulja
Copy link
Author

shikulja commented Aug 29, 2020

It takes a lot of work. What can be done first of all:

  • NPCDB move from language modules to one in the libs\ folder (like normal lib)
  • update dewdrop (not compatible with new)
  • Babble-Boss\Spell replace with universal versions, and move them to the libs\ folder from language modules, Babble-Spell has some inappropriate code, take it out separately
  • DPSMate_Parser & loc**.lua :
    move all languages ​​to the Localization\ directory, which will have a common entry in toc. (Regardless of the quality of translation of all languages, they are, and there are no alternatives, they will still be updated along with the core, and only the necessary lua languages ​​will be selected from the current

@tdymel
Copy link
Owner

tdymel commented Oct 30, 2020

Did your PR solve this?

@shikulja
Copy link
Author

@Geigerkind
No, I only updated the Russian localization. This does not change the structure of the add-on to be more compatible with external libraries, and a more cohesive look of files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants