-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test cases #18
Comments
As long as there's talk of refactoring, is it ok if I rewrite the tests for utest? nanotest is ok but has a number of small flaws, such as not working with DCE. Since both libraries are based on the same thing, their APIs are quite similar, and I expect most of the process to be find-and-replace. |
I'm fine with it, though I'll probably be a little slow to review. I'm not particularly opinionated about the unit test library (I don't plan on adding to hxmath myself much anytime soon). Seems like utest has more features and nanotest hasn't been updated in 4 years. |
Ok, I've switched to utest and put the actual/expected arguments in order. That leaves naming/organization, which is harder to pin down. After one pass through the files, here are problems I'd like to address:
As for my approach? I'd like to group the tests by related classes. For instance, OTOH, some of these files might get really long, so I might have to break them into subcategories. But unless you can think of something better, I'm going to start with this. |
Test cases have gotten messy. Need more consistent naming/organization and actual/expected parameters should be specified in the correct places (they're switched in most).
The text was updated successfully, but these errors were encountered: