Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Framework #17

Open
LeStarch opened this issue Sep 23, 2014 · 6 comments
Open

Plugin Framework #17

LeStarch opened this issue Sep 23, 2014 · 6 comments

Comments

@LeStarch
Copy link

The AutoAck code is becoming slightly hard to maintain due to many different commands all being part of a centralized "if" statement in the main loop. It is not strictly clear where or how to add new functionality. However, the basic functionality of any action remains simple:

On receive message m from user u, perform action(m,u).
onMessage(m,u)

Therefore, a simple plugin framework can be created so that every plugin is clean, and implements a small set of functions. This simplifies adding new code.

This issue is to add a simple framework for plugins and refactor basic actions of the Auto-Ack to be implemented that framework. It also constitutes the refactor of basic actions into "Plugins"

Plugin Framework:
Class:
Function 1: run(user,message)
Runs this plugin with IRC message consisting of given 'message' from given 'user'
Function 2: list()
Allows user to list commands supported by this plugin.

@chrismattmann
Copy link
Collaborator

yes, this makes total sense to me. ack.

@lewismc
Copy link
Collaborator

lewismc commented Sep 23, 2014

Seen

@LeStarch
Copy link
Author

https://github.com/LeStarch/AutoAck has the changes for this issue. Once I finish testing Tweet functionality I will issue a pull request and this functionality can be brought into the fold.

@lewismc
Copy link
Collaborator

lewismc commented Sep 23, 2014

Bewm

On Tuesday, September 23, 2014, LeStarch [email protected] wrote:

https://github.com/LeStarch/AutoAck has the changes for this issue. Once
I finish testing Tweet functionality I will issue a pull request and this
functionality can be brought into the fold.


Reply to this email directly or view it on GitHub
#17 (comment).

Lewis

@tbpalsulich
Copy link
Owner

I like this idea. We may even consider entirely separate AutoAck programs -- one for IRC, one for Twitter, GitHub, etc. Each program could call the same plugins to get the proper responses.

So, we would have plugins for services (IRC, Twitter, etc, each with specific response protocols), and each of those has possibly overlapping plugins for how to respond. Does that make sense?

@lewismc
Copy link
Collaborator

lewismc commented Sep 24, 2014

Makes about as much sense as AutoAck...
Chocalate radiator springs to mind!!!

On Tue, Sep 23, 2014 at 3:53 PM, Tyler Palsulich [email protected]
wrote:

I like this idea. We may even consider entirely separate AutoAck programs
-- one for IRC, one for Twitter, GitHub, etc. Each program could call the
same plugins to get the proper responses.

So, we would have plugins for services (IRC, Twitter, etc, each with
specific response protocols), and each of those has possibly overlapping
plugins for how to respond. Does that make sense?


Reply to this email directly or view it on GitHub
#17 (comment).

Lewis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants