Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphiQL custom header support #116

Open
upcFrost opened this issue Sep 30, 2020 · 5 comments
Open

GraphiQL custom header support #116

upcFrost opened this issue Sep 30, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@upcFrost
Copy link

Hi,

Upstream GraphiQL (https://github.com/graphql/graphiql/tree/main/packages/graphiql) seem to support setting custom headers (e.g. authorization) when the headerEditorEnabled option is set, it provides additional tab similar to "Query Variables".

Is it possible to add similar headers editor tab to the GraphiQL template used in tartiflette-aiohttp?

@abusi
Copy link
Contributor

abusi commented Sep 30, 2020

@upcFrost If I understand correctly, you want us to update our integration of graphiql to the latest upstream so you could use the graphiql_options to pass {"headerEditorEnabled": True} to it ?

@upcFrost
Copy link
Author

yes

@upcFrost
Copy link
Author

though I think the current template (https://github.com/tartiflette/tartiflette-aiohttp/blob/master/tartiflette_aiohttp/_graphiql.html) does not support it

@abusi abusi added the enhancement New feature or request label Sep 30, 2020
@abusi
Copy link
Contributor

abusi commented Sep 30, 2020

@upcFrost If you think you can do it, i'll gladly approve and release a new version. I may have some time to do it next week.

@upcFrost
Copy link
Author

Ok, I'll try to, probably in the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants