Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Logins section and empty strings #505

Open
chrobryknur opened this issue Apr 8, 2021 · 0 comments
Open

Recent Logins section and empty strings #505

chrobryknur opened this issue Apr 8, 2021 · 0 comments

Comments

@chrobryknur
Copy link

Hi!
I've just found that that the recent_account_logins() function in linux_json_api.sh script doesn't provide any check whether the "From" column of lastlog output is a non-empty string. It results in a weird formatting of the Recent Logins section on the Dash:
image

The awk script in the recent_account_logins() that the lastlog's output is piped to, just prints a hardcoded set of columns, which just "shifts" some of them to the left if one is an empty string, making the first part of the date appear in the IP column.

My lastlog's output:

Username       Port     From                Latest
root             tty5                      Thu Apr  8 22:58:30 +0200 2021
daemon                                     **Never logged in**
...
sddm                                       **Never logged in**
marcin           pts/3    192.168.1.14     Thu Apr  8 23:01:25 +0200 2021
systemd-coredump                           **Never logged in**
...
Debian-gdm                                 **Never logged in**

I am willing to fix this issue, when I find some time. Just wanted to inform you about the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant