Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior related to user confirmations for operation varies for different commands #978

Open
elhimov opened this issue Oct 9, 2024 · 0 comments
Labels
2sp code health Improve code readability, simplify maintenance and so on teamE

Comments

@elhimov
Copy link
Contributor

elhimov commented Oct 9, 2024

The mentioned differences can be divided into following topics:

  1. Confirmation target
    restart and kill commands ask for confirmation once and if confirmed apply the corresponding operation for all instances (when target implies multiple instances, like app-target in case of multi-instances application)
    clean asks confirmation for every single instance implied by target.
  2. Discard reply
    restart displays text • Restart is cancelled.
    kill produces no output, just finish the execution.
    clean displays • instance: cleaning... [ERR] canceled by user after every discarding.
  3. State validation
    clean only asks for confirmation if an instance is not running, otherwise just skips it with displaying instance `some_instance` must be stopped
    kill asks for confirmation regardless of instances states.

Consider using the single approach.

@oleg-jukovec oleg-jukovec added 2sp teamE code health Improve code readability, simplify maintenance and so on labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2sp code health Improve code readability, simplify maintenance and so on teamE
Projects
None yet
Development

No branches or pull requests

2 participants