Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUI-92 - Streams in Dashboard #178

Merged
merged 3 commits into from
Oct 20, 2021
Merged

TUI-92 - Streams in Dashboard #178

merged 3 commits into from
Oct 20, 2021

Conversation

jardmclan
Copy link
Collaborator

Overview:

Add projects listing to dashboard

Related Github Issues:

Summary of Changes:

  • Add projects to dashboard

Testing Steps:

UI Photos:

image

Notes:

Dashboard link not implemented, will be implemented in further pr

@jardmclan jardmclan requested a review from jchuahtacc October 13, 2021 01:41
src/index.tsx Show resolved Hide resolved
src/index.tsx Show resolved Hide resolved
@@ -107,6 +109,14 @@ const Dashboard: React.FC = () => {
counter={`${jobs?.data?.result?.length} jobs`}
loading={jobs?.isLoading}
/>
<DashboardCard
icon="project"
name="Projects"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to Streams? Since that is the top level name of the service.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Streams is the top level name this group of services falls into, but this tile displays the number of Projects. The UI should specify that this is what it is showing, saying it shows the number of streams would not make sense.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have other uses for the word "Projects" in future downstream consumers of tapis-ui. This card should have Streams as a title but the text can remain 100 projects. In theory, this could be built out to have more detail, like 100 projects, 20 instruments etc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, the dashboard cards and side nav consistently represent the top level services.

@@ -107,6 +109,14 @@ const Dashboard: React.FC = () => {
counter={`${jobs?.data?.result?.length} jobs`}
loading={jobs?.isLoading}
/>
<DashboardCard
icon="project"
name="Projects"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have other uses for the word "Projects" in future downstream consumers of tapis-ui. This card should have Streams as a title but the text can remain 100 projects. In theory, this could be built out to have more detail, like 100 projects, 20 instruments etc.

@@ -107,6 +109,14 @@ const Dashboard: React.FC = () => {
counter={`${jobs?.data?.result?.length} jobs`}
loading={jobs?.isLoading}
/>
<DashboardCard
icon="project"
name="Projects"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, the dashboard cards and side nav consistently represent the top level services.

@jchuahtacc jchuahtacc merged commit d3f407e into TUI-94--streams-pages Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants