Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE] Need different formula for reward calculation #243

Open
akileshtangella opened this issue Feb 2, 2023 · 0 comments
Open

[ISSUE] Need different formula for reward calculation #243

akileshtangella opened this issue Feb 2, 2023 · 0 comments

Comments

@akileshtangella
Copy link
Contributor

akileshtangella commented Feb 2, 2023 •
edited
Loading

Right now, inside the claims circuit we are calculating anonymity points reward as:
rate * (time in the MASP in milliseconds) * maspRecordAmount.

This amount can easily exceed 248 bits, but it must be within 248 bits since we are inserting anonymity points into a VAnchor and this check exists: https://github.com/webb-tools/protocol-solidity/blob/main/circuits/vanchor/transaction.circom#L111-L113
@dutterbutter dutterbutter moved this to Not Started 🕧 in Webb Universe Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Webb Universe
Status: Not Started 🕧
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akileshtangella