Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code suggestions JOSS #78

Open
jonsampedro opened this issue Jun 9, 2024 · 0 comments
Open

Code suggestions JOSS #78

jonsampedro opened this issue Jun 9, 2024 · 0 comments

Comments

@jonsampedro
Copy link

openjournals/joss-reviews/issues/6797

The code is clear and the structure seems to be consistent across the different scripts. However, I have tried to run devtools::check() and it does not work due to the following error associated with the vignettes:
image

Also, I have needed to install some additional dependencies for the check:
image

I have some minor comments:

  • Due to the dependency with the “parallel” package (which is integrated in core R), RSWAT requires the latest versions of R (>4.1.1), so it needs to be added.
  • There are some other dependencies that are missing and not included in the DESCRIPTION file(e.g., 'magrittr' 2.0.1 is being loaded, but >= 2.0.3 is required)
  • If the selected directory (tempdir) does not exist, the package should create the folder in the system
  • Consider creating a documentation website using the “pkgdown” (or a similar) package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant