-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TYPE 3] - Add "max_filesize" parameter to a workbook's download
method
#1500
Comments
So you want the user to be able to set a maximum size, and if the workbook size exceeds this user defined value, don't download? |
Yes exactly - "only download the file if it's less than X units." I had megabytes in mind but open to whatever makes the most sense This is because the size of workbook files can vary greatly, and I've seen them range from a couple kilobytes to a couple gigabytes. It would put a strain on our server's resources to download too large of files |
Workbooks and datasources have a |
There's a problem with tableau's rest api, where the "Get Workbook" endpoint returns a constant |
Actually sorry, only for some workbooks - maybe workbooks less than 1 mb are being rounded up to 1? I haven't had much time to troubleshoot this problem specifically, sorry for the lack of information |
Can you try checking how many you have of each? print("1mb workbooks", len(server.workbooks.filter(size="1")))
print(">1mb workbooks", len(server.workbooks.filter(size__gt="1"))) |
Description
It would be helpful to be able to pass a
max_filesize
parameter to a workbook's download method that will return early if a workbook is too large 🙂The text was updated successfully, but these errors were encountered: