Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus value not exported anymore after using execute #213

Open
viralatadesbois opened this issue Mar 4, 2024 · 4 comments
Open

Focus value not exported anymore after using execute #213

viralatadesbois opened this issue Mar 4, 2024 · 4 comments

Comments

@viralatadesbois
Copy link

Hi,
We use a lot of thick material so we make the focus on the surface for engraving and have a focus value for each material set to minus half the thickness (for example for 8mm mdf the cut setting has a focus of -4mm)
We generaly export the gcode and send it to the laser cutter via its web interface (it's a Robotseed lasercutter with a smoothieboard). And it works fine.
But to spare some times we also use the "execute" button from visicut to send the gcode directly. This is where we have a strange behavior:

  • the first time we use "execute" everything is fine but then the focus value is not sent anymore, and even if we export the gcode after this first execute the focus value is not exported until we close and start again visicut.
    We use visicut 1.9-200 on linux and windows 11 with the same behavior and it's the same on visicut 2.0-4 on linux.
    Anybody with the same issue ? Any idea how to solve it ?

Thank you.

@mgmax
Copy link
Collaborator

mgmax commented Mar 4, 2024 via email

@mgmax
Copy link
Collaborator

mgmax commented Mar 4, 2024 via email

@viralatadesbois
Copy link
Author

Visicut-offset-problem.zip

Thank you for your answer.
It happens fot what it seems everytime, wathever the offset (positive or negative) we use.
I joined our config, and 2 gcodes of the same file exported before and after the "execute" command and we see the line with G0 Z-3 disapeared.

@mgmax
Copy link
Collaborator

mgmax commented Mar 5, 2024

oops... without even looking at your file, I now remember that I almost fixed that bug two years ago but never found time to finish that...

So the issue is in LibLaserCut, the library that provides the laser drivers of VisiCut. Moving the issue over to there.

See #177 :
The currentFocus variable is not reset correctly, so sending the same job twice does sometimes not have the same content.

We should also add a test against such bugs in LibLaserCut. We already have some tests that check that the content is the same when the same job is sent twice . These were introduced in 8443554 but specifically for the focus we don't do that yet.

@mgmax mgmax transferred this issue from t-oster/VisiCut Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants