-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing circles with fast signing speed #716
Comments
You could try turning off throttling https://github.com/szimek/signature_pad#options |
It is already turned off (set to 0). Can you reproduce this issue? |
I can't reproduce this. There is a sensitivity setting on smartphones to prevent accidental touches. My guess is that is too high for fast signatures |
I forgot to say that the signature is drawn on the canvas correctely but when exporting the svg some circles are missing. Sorry for that. You can check this also on the demo page. It also happend there (in my case). |
Can you provide a list of data points that it does this to? And a video of this happening could be helpful. Also provide information on what type of phone and browser it is. |
I have tried many times to reproduce it. It doesn't happen for me. If you could get the data points I could try debugging it. |
Did you tap very quickly to generate circles? I will export a data array for you... |
Can you paste the data here so I can copy it? |
I did a new one in the previous post. Here is the array for that: |
I wonder if this isn't a bug in toSvg but a race condition when adding points. |
I do not understand. What´s a race condition? I wonder why this does not happen to you. I tried it with 2 different smartphones and a Macbook and was able to reproduce it with all devices. |
A race condition is when two events happen fast and the order of events gets mixed up. For example when adding two dots to the canvas signature_pad expects the events to come in as "begin dot 1", "end dot 1", "begin dot 2", "end dot 2". If the dots are added very fast the events might be able to come in as "begin dot 1", "begin dot 2", "end dot 1", "end dot 2". That would be a race condition. Most likely I am not able to recreate it because my phone is fast enough to call the events in the right order. You said at the beginning that this seems to happen with slower processor speeds. What we need to figure out is how to get signature_pad to do the correct thing when these events come in out of order. |
Ok, got that. That sounds plausible. |
I found out that there are single circles (when signing dots) missing sometimes especially when using higher signing speed and slower processors (smartphones). Is there a workaround?
The text was updated successfully, but these errors were encountered: