Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about js/css compressor ? #771

Open
montabou opened this issue Jul 8, 2014 · 2 comments
Open

Question about js/css compressor ? #771

montabou opened this issue Jul 8, 2014 · 2 comments

Comments

@montabou
Copy link
Contributor

montabou commented Jul 8, 2014

I was wondering why the yui_js and yui_css compressors are hardcoded in https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle/blob/master/Resources/views/base_admin.html.twig

I see different problems about that:

I think there are 2 solutions:

  • simply remove the js/css compressor and let the user to compress js/css using apply_to paramater of assetic (- Pro: do not require people to install extra compressor that they may not use - Con: js/css are not optimized with s2admingenerator default parameters)
  • compress with a php compressor as https://github.com/mrclay/minify and/or https://github.com/natxet/cssmin (- Pro: works using only php - Con: Force user to compress using s2admingenerator compressor configuration)

Waiting for your feedback, I can do a PR if you want.
For me the best choice is the first one that let the user to configure js/css stuffs as he wants

@bobvandevijver
Copy link
Member

@ioleo
Copy link
Member

ioleo commented Jul 9, 2014

I'm planning to change to uglifyjs and uglifycss soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants