Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Evaluate links for descriptor is broken #131

Open
ElectricMaxxx opened this issue Jan 25, 2018 · 0 comments · May be fixed by #140
Open

Evaluate links for descriptor is broken #131

ElectricMaxxx opened this issue Jan 25, 2018 · 0 comments · May be fixed by #140

Comments

@ElectricMaxxx
Copy link
Member

this:
https://github.com/symfony-cmf/sonata-phpcr-admin-integration-bundle/blob/master/src/Description/SonataEnhancer.php#L81
can not work. No idea why i fixed it that way, maybe cause the test doesn't match real admin names.
Something like:

$linkKey = substr($code, strlen($admin->getCode()) + 1);

looks more valid. So we should fix it and write more meaningfull tests for that case.

@EmmanuelVella EmmanuelVella linked a pull request Jan 8, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant