Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why RedisQues spreads redisAPI.send() call to several threads? #198

Open
hiddenalpha opened this issue Jul 1, 2024 · 0 comments
Open

Why RedisQues spreads redisAPI.send() call to several threads? #198

hiddenalpha opened this issue Jul 1, 2024 · 0 comments

Comments

@hiddenalpha
Copy link
Member

Why does RedisQues spread those 'redisAPI' calls to several threads in QueueStatisticsCollector? It should be just fine to call 'redisAPI.send()' directly from EventLoop. Unluckily, original code does not tell us anything about this.

IMHO there are TWO ways to resolve this issue:

  • Make sure redisAPI never ever blocks the EventLoop thread so we can just remove 'executeBlocking()' and call 'redisAPI' directly.
  • Explain, AS A COMMENT, DIRECTLY WITHIN THE AFFECTED CODE, in an UNAMBIGUOUS way, WHY RedisQues has to use 'executeBlocking()' in this specific case. I guess maybe Is Vertx Redis API blocking? #165 could be the reason?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant