Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftOutputChannel test prints lots of errors #1197

Open
award999 opened this issue Nov 4, 2024 · 0 comments
Open

SwiftOutputChannel test prints lots of errors #1197

award999 opened this issue Nov 4, 2024 · 0 comments
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases

Comments

@award999
Copy link
Contributor

award999 commented Nov 4, 2024

With latest vscode there are a lot of error messages printed to the console:

  SwiftOutputChannel
    ✔ Appends logs
Error: Trying to add a disposable to a DisposableStore that has already been disposed of. The added object will be leaked!
    ✔ Appends lines
    at H3.add (file:///d:/a/vscode-swift/vscode-swift/.vscode-test/vscode-win32-x64-archive-1.95.1/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:24:1439)
    ✔ Appends lines and rolls over
    at yw.n (file:///d:/a/vscode-swift/vscode-swift/.vscode-test/vscode-win32-x64-archive-1.95.1/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:120:1748)
    ✔ Appends and rolls over
@award999 award999 added the testing infrastructure Issues related to CI jobs or extension test cases label Nov 4, 2024
plemarquand added a commit to plemarquand/vscode-swift that referenced this issue Nov 5, 2024
@plemarquand
Fix warnings printed during SwiftOutputChannel tests
b0cecbd 
Output channels were not designed to be created and immediately
disposed because they're added to the disposable store internal to VS
Code asynchronously.

Issue swiftlang#1197
@plemarquand plemarquand mentioned this issue Nov 5, 2024
Merged
@plemarquand plemarquand self-assigned this Nov 5, 2024
@award999 award999 added the needs verification Issue has been fixed, but requires verification before closing label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases
Projects
Swift Extension for Visual Studio Code
Status: Needs Verification
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plemarquand @award999