New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use toolchain's swift-format as a formatting provider #1193

Closed

MahdiBM wants to merge 1 commit into swiftlang:main from MahdiBM:mmbm-swift-format

MahdiBM commented Nov 3, 2024 •

edited

Loading

resolves #1190

Inspired by https://github.com/vknabel/vscode-apple-swift-format

Checklist:

Create and register a formatting provider that calls swift format.
Test the PR locally.
Proper error handling.
Make sure user toolchain has swift-format bundled with it.

I'm not a typescript dev, maintainer folks you can feel free to show the obvious problems, or even nit pick.


          initial try - add formatting provider and register it

032192e

Author

MahdiBM commented Nov 5, 2024

Looks like sourcekit-lsp is the proper place for this implementation to go to: #1190 (comment)

MahdiBM closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

adam-fowler Awaiting requested review from adam-fowler adam-fowler will be requested when the pull request is marked ready for review adam-fowler is a code owner

0xTim Awaiting requested review from 0xTim 0xTim will be requested when the pull request is marked ready for review 0xTim is a code owner

award999 Awaiting requested review from award999 award999 will be requested when the pull request is marked ready for review award999 is a code owner

Labels

None yet