Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode / Light Mode in new online Swift Book #119

Closed
alebmp opened this issue Feb 26, 2023 · 6 comments
Closed

Dark Mode / Light Mode in new online Swift Book #119

alebmp opened this issue Feb 26, 2023 · 6 comments

Comments

@alebmp
Copy link

alebmp commented Feb 26, 2023

Description

I would like to point out that in the new format of the Swift Book (on Swift.org), a footer has been inserted which does not allow the dark mode/light mode switch to be seen and used. The mode therefore depends solely on the general setting of the Mac. In my case, this is definitely inconvenient because I can only use Dark Mode which (at least for me) is very annoying.

I don't know if this is the right place for this report, and if not, I apologise.

Steps to reproduce

Expected behavior

Environment

  • Swift compiler version info
  • Xcode version info
  • Deployment target:
@AnthonyLatsis
Copy link

cc @shahmishal

Not sure if this belongs in the website or swift-book repo.

@benrimmington
Copy link
Contributor

Can this issue be transferred to Swift-DocC-Render, as suggested by @krilnon on the forums?

https://forums.swift.org/t/light-mode-for-swift-5-8-docs/63364/6

@AnthonyLatsis
Copy link

@krilnon Do you have commit access here to transfer this issue?

@krilnon krilnon transferred this issue from swiftlang/swift Mar 17, 2023
@krilnon
Copy link
Contributor

krilnon commented Mar 17, 2023

Thanks for the ping; somehow I missed Ben's earlier. This is fixed by #110 for this book, and I filed a broader issue for DocC-Render here: swiftlang/swift-docc-render#546.

@griffrawk
Copy link

Could I make a request for dark mode to be not-so-dark mode? Or at least an option of an in-between like the Rust book has? The current dark mode contrast is a bit too stark, so the the white lettering is also a bit too strong.

@amartini51
Copy link
Member

@griffrawk Can you open an issue against DocC about that please? It's good feedback, but TSPL doesn't define its own style sheet. It just uses the colors that come from DocC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants