From f937cf69ce564b81a1d0c6acf487875deda45c99 Mon Sep 17 00:00:00 2001
From: J S <49557684+svilupp@users.noreply.github.com>
Date: Sat, 23 Dec 2023 12:52:10 +0100
Subject: [PATCH] improve tests

---
 test/Experimental/RAGTools/generation.jl | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/test/Experimental/RAGTools/generation.jl b/test/Experimental/RAGTools/generation.jl
index 51d70edbb..b19d03a44 100644
--- a/test/Experimental/RAGTools/generation.jl
+++ b/test/Experimental/RAGTools/generation.jl
@@ -95,7 +95,8 @@ end
         tag_filter = ["yes"],
         return_context = false)
     @test occursin("Time?", msg.content)
-    # different kwargs
+
+    ## Test different kwargs
     msg, ctx = airag(index; question = "Time?", model_embedding = "mock-emb",
         model_chat = "mock-gen",
         model_metadata = "mock-meta", api_kwargs = (; url = "http://localhost:$(PORT)"),
@@ -111,6 +112,19 @@ end
     @test ctx.filtered_candidates.distances == 0.5ones(2)
     @test ctx.reranked_candidates.positions == [2, 1] # no change
     @test ctx.reranked_candidates.distances == 0.5ones(2) # no change
+
+    ## Not tag filter
+    msg, ctx = airag(index; question = "Time?", model_embedding = "mock-emb",
+        model_chat = "mock-gen",
+        model_metadata = "mock-meta", api_kwargs = (; url = "http://localhost:$(PORT)"),
+        tag_filter = nothing,
+        return_context = true)
+    @test ctx.context == ["1. b\nc", "2. a\nb\nc", "3. a\nb"]
+    @test ctx.emb_candidates.positions == [3, 2, 1]
+    @test ctx.emb_candidates.distances == zeros(3)
+    @test ctx.tag_candidates == nothing
+    @test ctx.filtered_candidates.positions == [3, 2, 1] #re-sort
+    @test ctx.reranked_candidates.positions == [3, 2, 1] # no change
     # clean up
     close(echo_server)
 end