Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on incorrect attributes for svelte:body #13084

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Aug 30, 2024

Fixes #13021. We should be throwing an error when spreading to <svelte:body> as there might be an expectation that these work (they don't work today).

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 2840c07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm good with this approach. We can always relax it non-breakingly in future if we need to

@trueadm trueadm merged commit cf6b64c into main Aug 30, 2024
9 checks passed
@trueadm trueadm deleted the disallow-spread-body branch August 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Assigning event listener to svelte:body with spread operator does not register it
2 participants