Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert comment before text in an each block, to prevent glued nodes #13073

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Rich-Harris
Copy link
Member

fixes #12913

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 45f1df3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

is_text_first:
(parent.type === 'Fragment' ||
parent.type === 'SnippetBlock' ||
parent.type === 'EachBlock' ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we only do this if preserveWhitespace is true to avoid the extra anchors?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would break the case where you have only text nodes:

{#each 'abc' as l}
	{l}
{/each}

It doesn't result in a hydration mismatch, likely because it's repaired, but from debugging I can clearly see it wrongly fuses the text nodes together and hydration does destroy and recreated nodes.

@Rich-Harris Rich-Harris merged commit 0203eb3 into main Aug 30, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the gh-12913 branch August 30, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration regression between 224 and 225
3 participants