git commit message with reserved word cannot build in GitLab CI #6102
Comments
|
Oh my gosh, I usually feel bad when features I implement introduce a bug, but honestly, even on my absolute best day ever, I would never have seen this one coming. |
|
I'm not so sure this is a Kit issue, though, at least not if the issue is caused by what we think it is. Regardless of the fact that the environment variable contains |
elliott-with-the-longest-name-on-github
added
bug
|
I think this is an error somewhere in Vite. When I make a more minimal reproduction locally, I get the following:
Curious to see if any Viteheads have more to add... |
|
Filed vitejs/vite#9790. Going to consider this "blocked by upstream" until we hear back from the team. |
|
PR already open upstream! |
|
This seems to be fixed by vitejs/vite#11151 and I can't reproduce the original issue either. Going to close this one as resolved. |
Describe the bug
OK here's a weirdo one. I build my project using
yarn build(vite build) in GitLab CI, then rsync the compiled bundle/code to my server that's running a simple node server (i.e. I'm using adapter-node), and then GitLab CI then restarts the service on the remote.I am actually writing this because I've updated Kit to the very latest today, and I had to re-work how I was using environment variables (I shifted from import.meta.env to $env/static/public and $env/static/private).
My commit message was then something like "refactor to remove import.meta.env" -- but GitLab puts certain environment variables in the build environment, such as CI_COMMIT_TITLE. Kit then tries to pull them all in to the static build, but as it contains the word "import," it is rejected, and my build soft fails.
I think that this is happening in kit/src/core/env.js (that's where I found references to this being a reserved word).
Looking up at utils.js/get_env, it doesn't seem there's a way to ignore/exclude certain variables from the build. (This would work for me as all GitLab's variables start with
CI_and I could filter those out.)After I did another commit message without a reserved word, all was fine with the build.
Using
Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-gvupwf?file=src/routes/+page.svelte
Once in the stackblitz, stop the development server and issue:
CI_COMMIT_TITLE="do not use import.meta.env" npm run buildAnd the error happens.
Logs
System Info
System: OS: macOS 12.4 CPU: (8) arm64 Apple M1 Pro Memory: 73.84 MB / 32.00 GB Shell: 5.8.1 - /bin/zsh Binaries: Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm Watchman: 2022.06.06.00 - /opt/homebrew/bin/watchman Browsers: Brave Browser: 104.1.42.95 Chrome: 104.0.5112.101 Firefox Developer Edition: 104.0 Safari: 15.5 npmPackages: @sveltejs/adapter-auto: ^1.0.0-next.50 => 1.0.0-next.64 @sveltejs/adapter-node: ^1.0.0-next.67 => 1.0.0-next.86 @sveltejs/kit: ^1.0.0-next.260 => 1.0.0-next.424 svelte: ^3.44.0 => 3.49.0 vite: ^3.0.9 => 3.0.9Severity
annoyance
Additional Information
I think the proper thing would be to write in a way to exclude certain variables or a certain RegEx of variables as "do not build these into env/static"
I think this would happen maybe in get_env:
...with perhaps an additional entries.filter??
The text was updated successfully, but these errors were encountered: