Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SurveyModel: Split the showPreviewBeforeComplete property in two #5351

Open
RomanTsukanov opened this issue Dec 16, 2022 · 0 comments · May be fixed by #9244
Open

SurveyModel: Split the showPreviewBeforeComplete property in two #5351

RomanTsukanov opened this issue Dec 16, 2022 · 0 comments · May be fixed by #9244
Assignees
@tsv2013
Labels
API change Issues that request changes in the API v2.0

Comments

@RomanTsukanov
Copy link
Contributor

RomanTsukanov commented Dec 16, 2022 •
edited
Loading

Properties that start with a verb should enable or disable a feature, therefore they should accept only Boolean values. We should split the showPreviewBeforeComplete in two:

showPreviewBeforeComplete: true | false,
previewMode: "allQuestions" | "answeredQuestions"
@RomanTsukanov RomanTsukanov added the API change Issues that request changes in the API label Dec 16, 2022
tsv2013 pushed a commit that referenced this issue Dec 31, 2024
SurveyModel: Split the showPreviewBeforeComplete property in two
9f47c1f 
Fixes #5351
@tsv2013 tsv2013 linked a pull request Dec 31, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsv2013 tsv2013

Labels
API change Issues that request changes in the API v2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SurveyModel: Split the showPreviewBeforeComplete property in two surveyjs/survey-library
2 participants
@tsv2013 @RomanTsukanov