Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify safeupdate usage to fit with extension changes #27892

Closed
wants to merge 2 commits into from

Conversation

encima
Copy link
Member

@encima encima commented Jul 10, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

docs update

What is the current behavior?

Current behaviour is inconsistent across project versions and can result in permissions errors

What is the new behavior?

New behaviour loads safeupdate by default into shared_preload_libraries (for all versions after 15.1.173) and can then be enabled on a per-role basis.

Closes supabase/postgres#1308

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 8:36am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 8:36am
studio ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 8:36am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 8:36am
studio-staging ⬜️ Skipped (Inspect) Aug 15, 2024 8:36am
zone-www-dot-com ⬜️ Skipped (Inspect) Aug 15, 2024 8:36am

Copy link

supabase bot commented Jul 10, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

Copy link

Copy link
Contributor

@charislam charislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that a formatting run causing blog changes? 🤔 If you revert those, it won't be blocked on marketing approval 😄

@encima encima force-pushed the docs/pg-safeupdate-amendments branch from d911de1 to 76f4d83 Compare July 11, 2024 21:08
@encima encima requested a review from charislam July 11, 2024 21:09
@encima encima removed the autofix label Jul 11, 2024
@vercel vercel bot temporarily deployed to Preview – studio-staging August 15, 2024 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com August 15, 2024 08:20 Inactive
@joshenlim
Copy link
Member

the page pg-safeupdate.mdx no longer exists on the latest master - will hence be closing this PR as the changes here are probably no longer relevant? Please do let me know otherwise 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use safeupdate for the database nor the postgres user (session_preload_libraries)
4 participants