Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect built-in scalars #83

Open
stuebingerb opened this issue Nov 13, 2024 · 0 comments
Open

Incorrect built-in scalars #83

stuebingerb opened this issue Nov 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@stuebingerb
Copy link
Owner

stuebingerb commented Nov 13, 2024

KGraphQL currently defines the following built-in scalars:

STRING
SHORT
INT
DOUBLE
FLOAT
BOOLEAN
LONG

However, the spec defines the following:

Int, Float, String, Boolean, and ID

According to the spec, those must be supported and also behave in a special way during introspection (which likely is not correctly implemented either).

So:

IMHO, Short and Long can still be included as built-in "extended" types to save users of the library from having to define them on their own but they must not behave like GraphQL built-in types. We can then also think about adding other common JVM types to those extended built-ins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant