Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate since and with-baseline mutually exclusive #2721

Closed
danihengeveld opened this issue Oct 14, 2023 · 0 comments · Fixed by #2723
Closed

Validate since and with-baseline mutually exclusive #2721

danihengeveld opened this issue Oct 14, 2023 · 0 comments · Fixed by #2723
Assignees
Labels

Comments

@danihengeveld
Copy link
Contributor

danihengeveld commented Oct 14, 2023

Is your feature request related to a problem? Please describe.
At the moment, it is possible to use the --since and --with-baseline flags at the same time, but we want this to be mutually exclusive.

Describe the solution you'd like
We want to add the following validation:

  • If --with-baseline is passed, --since may not be passed.

For both of these scenarios, we want to throw an InputException.

Describe alternatives you've considered
In the near future, we want to make these options into explicit commands. See: #2124, #2554. This way, the user needs to explicitly choose which one to use. But this requires some work to be done to the cli/command setup first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants