Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New progress reporter not working on wndows/MINGW64 #212

Closed
nicojs opened this issue Jan 2, 2017 · 5 comments · Fixed by #213
Closed

New progress reporter not working on wndows/MINGW64 #212

nicojs opened this issue Jan 2, 2017 · 5 comments · Fixed by #213

Comments

@nicojs
Copy link
Member

nicojs commented Jan 2, 2017

The new progress reporter is not showing up in MINGW64, which is the terminal installed by default using the git installer.

@nicojs
Copy link
Member Author

nicojs commented Jan 2, 2017

I did some more investigation. It turns out that the current progress reporter will never work on windows/MINGW64. Or to be more accurate, on windows + mintty (no idea what the difference is exactly).

It works when you start stryker directly using node (as in node node_modules/.bin/stryker run) but not as you let git bash host the node process (as in node_modules/.bin/stryker run).

The way i see it, we have 3 choices:

  1. Choose to log an error and don't do progress reporting. Maybe even explain how to solve it (i.e. use cmd or start stryker directly with a node command).
  2. Log an error/warning and fallback on the dots reporter (not ideal)
  3. Log an error/warning and fallback on a new minimalistic progress reporter. Just log every tenth mutant what the progress percentage is, including number killed, survived, etc.

@bkimminich and @simondel which one should we choose. I would prefer the 3th solution, although it's more work.

Background info:
When using mintty and you start a new process, it's not a true integrated command line anymore. Instead it's a pipe (without input stream). Things like stream.clearLine and stream.columns are not supported. The progress bar is smart and just returns without drawing the progress bar. We should check process.stderr.isTTY before calling the progress reporter. For more information see: nodejs/node#3006

@avassem85
Copy link
Contributor

Maybe this can help as well? visionmedia/node-progress#110

@simondel
Copy link
Member

simondel commented Jan 2, 2017

That's very strange. Nice find! I would prefer the third solution. We know the pattern so if all else fails we can just report every once in a while.

@nicojs
Copy link
Member Author

nicojs commented Jan 2, 2017

Hmm maybe i'll try to fix it in visionmedia/node-progress#110. Thanks @avassem85

@bkimminich
Copy link

I could live with dots, but the new shiny thing would of course be cooler, even with reduced refresh rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants