Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NpmArtifactControllerTest.packageNameTestBadRequest #1743

Closed
sbespalov opened this issue Apr 13, 2020 · 5 comments
Closed

Fix NpmArtifactControllerTest.packageNameTestBadRequest #1743

sbespalov opened this issue Apr 13, 2020 · 5 comments
Assignees
@anki2189
Labels
help wanted testing

Comments

@sbespalov
Copy link
Member

sbespalov commented Apr 13, 2020 •
edited by carlspring
Loading

Task Description

We need to fix this test against the issues/1649 branch.

The failed Jenkins build is here

Task Relationships

This task:

Help
@sbespalov sbespalov mentioned this issue Apr 13, 2020
Open
31 tasks
@anki2189
Copy link
Member

May I pick this?

@carlspring
Copy link
Member

Please, proceed!

@anki2189
Copy link
Member

This test is failing because NpmArtifactCoordinates#setVersion method is removed . This method was having Version validation, hence invalid package names test is failing.

@anki2189 anki2189 mentioned this issue Apr 13, 2020
Merged
10 tasks
@anki2189
Copy link
Member

@carlspring We can close this issue.

@carlspring
Copy link
Member

Thanks for looking into it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anki2189 anki2189

Labels
help wanted testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carlspring @anki2189 @sbespalov