Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Gremlin based UserEntry #1653

Closed
7 tasks done
sbespalov opened this issue Jan 23, 2020 · 10 comments
Closed
7 tasks done

Implement Gremlin based UserEntry #1653

sbespalov opened this issue Jan 23, 2020 · 10 comments
Assignees
Labels
help wanted in progress work is in progress

Comments

@sbespalov
Copy link
Member

sbespalov commented Jan 23, 2020

Task Description

The UserEnity should have a new repository class with Gremlin based CRUD and Spring Data Neo4j based custom Cypher queries. The UserRepository should be placed under org.carlspring.strongbox.gremlin.repositories.

Tasks

The following tasks will need to be carried out:

  • Re-work UserEntry class:
    • Create a UserEntity class with neo4j-ogm annotations
    • Re-work UserEntryService into UserRepository
    • Re-work OrientDbUserService into GremlinUserService
    • Replace all UserEntry references with UserEntity
    • Implement UserAdapter for UserRepository class
    • Provide Cypher queries with @Query annotation for UserQueries interface

Task Relationships

This task:

Help

@steve-todorov
Copy link
Member

steve-todorov commented Jan 23, 2020

@sbespalov could you please add a few words about the purpose of each of the mentioned classes and what they should be doing?

@carlspring
Copy link
Member

Some questions:

  • What should the UserAdapter be for exactly?
  • What should one keep in mind while migrating the OrientDbUserService into GremlinUserService? Are there some common steps to follow that could be used for other such services that will have to be migrated? (If so, could you please list them here for future reference? Thanks!).

@kaansonmezoz
Copy link

I'd like to work on this issue. But there are some things which should be cleared out.

  • What is the role of UserAdapter, what should be adapting from what ?
  • I've searched for OrientDbUserService in the code base and the only thing I found is that a variable named after orientDbUserService whose type is UserService. Is that what you meant by OrientDbUserService ? Do you mean UserService ?

@carlspring
Copy link
Member

carlspring commented Jan 23, 2020

@kaansonmezoz ,

This is a proof-of-concept based on the strongbox project. The code will initially (@sbespalov , please confirm, if this is how you envision it) be in strongbox-janusgraph-cassandra-poc where we have Janusgraph + Cassandra all set up.

@sbespalov
Copy link
Member Author

thank you all for interesing to this issue. There is some general explanations in master task, so please have a look at #1649. Also it would be good to see on how all the things implemented in strongbox-janusgraph-cassandra-poc. If there still will be a general questions please ask at #1649 comments.

@carlspring carlspring self-assigned this Feb 21, 2020
@carlspring carlspring added the in progress work is in progress label Feb 21, 2020
@steve-todorov
Copy link
Member

steve-todorov commented Mar 4, 2020

@sbespalov what is the state of this task? I believe @carlspring mentioned this has already been done and committed into #1649 ? Can we now close this or is there anything else needed to be done?

@sbespalov
Copy link
Member Author

@steve-todorov it's not implemented. probably @carlspring can clarify better what is the status.

@carlspring
Copy link
Member

@steve-todorov : There seems to be some sort of confusion.
@sbespalov : I thought I saw this implemented on your branch. :-D

@sbespalov
Copy link
Member Author

I've just fixed User related compilation issues, but this is just stubs withut implementation

@carlspring
Copy link
Member

Will be done as part of #1649 via #1676 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted in progress work is in progress
Projects
None yet
Development

No branches or pull requests

4 participants