Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember Token #22

Open
darthtaco opened this issue Sep 1, 2015 · 1 comment
Open

Remember Token #22

darthtaco opened this issue Sep 1, 2015 · 1 comment

Comments

@darthtaco
Copy link

Hi -
First thanks for your work on this. I've attempted to roll my own L5 ldap driver with varying degrees of success and this makes things much simpler.

I have a question regarding the 'remember token'. The LdapAuthUserProvider->retrieveByToken() method has a comment saying "this shouldn't bee needed as user / password is in ldap". However, I still feel there is a need to store a token in the database for when the user wants to automatically be logged in next time. Without storing it somewhere the user will not have the ability to 'remember me'. It seems this would be easy enough, but there may be a reason why it has not been implemented. I want to be sure I am using this the way it was intended and not recreate the wheel.

Any insights would be appreciated. Thanks again for your work on this.

@strebl
Copy link
Owner

strebl commented Sep 21, 2015

Hi @darthtaco
Sorry for ignoring your question over 20 days... Had not enough time in the last few weeks.

I know what you are trying to achieve. And it would be great. As you know, I forked the package and that's something I didn't change since then. But I think I know why ccovey did that. What if you have an remember me token and the user changes his password? There is no way the application knows when the password was changed.
Maybe we can store the password change time and check that on every login!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants