You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should investigate whether this is still necessary (unlikely), or if it is just an artifact from how the Device trait worked in smoltcp 0.8 and older (likely).
Removing that lifetime and impl-ing directly for EthernetDMA would also remove the current oddness w.r.t. requiring that an &mut &mut EthernetDMA is passed to smoltcp functions.
The text was updated successfully, but these errors were encountered:
datdenkikniet
changed the title
New smoltcp::Device implementation can be for EthernetDMA instead of &mut EthernetDMAsmoltcp::Device implementation can be for EthernetDMA instead of &mut EthernetDMAJul 28, 2023
The current implementation still has the following signature:
However, the
'a
lifetime is completely unused. We could change the impl toWe should investigate whether this is still necessary (unlikely), or if it is just an artifact from how the
Device
trait worked in smoltcp 0.8 and older (likely).Removing that lifetime and impl-ing directly for
EthernetDMA
would also remove the current oddness w.r.t. requiring that an&mut &mut EthernetDMA
is passed to smoltcp functions.The text was updated successfully, but these errors were encountered: