Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAME Versioning #927

Closed
damaestro opened this issue May 15, 2024 · 4 comments
Closed

SONAME Versioning #927

damaestro opened this issue May 15, 2024 · 4 comments

Comments

@damaestro
Copy link
Contributor

We need to configure proper soname's and versioning for downstream packaging policy compliance. The goal is to provide an ABI guarantee for any given soname. This can be accomplished by soname versioning or library symbol versioning. The simpler solution is likely the right one. Soname bumps are usually more involved and will require rebuilding all linked packages.

Fedora: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Debian: https://www.debian.org/doc/manuals/maint-guide/advanced.en.html#library

Based on the fedora-review tool, there are 15 sonames that need addressing:

# E: invalid-soname /usr/lib64/libpango_core.so libpango_core.so
# E: invalid-soname /usr/lib64/libpango_display.so libpango_display.so
# E: invalid-soname /usr/lib64/libpango_geometry.so libpango_geometry.so
# E: invalid-soname /usr/lib64/libpango_glgeometry.so libpango_glgeometry.so
# E: invalid-soname /usr/lib64/libpango_image.so libpango_image.so
# E: invalid-soname /usr/lib64/libpango_opengl.so libpango_opengl.so
# E: invalid-soname /usr/lib64/libpango_packetstream.so libpango_packetstream.so
# E: invalid-soname /usr/lib64/libpango_plot.so libpango_plot.so
# E: invalid-soname /usr/lib64/libpango_python.so libpango_python.so
# E: invalid-soname /usr/lib64/libpango_scene.so libpango_scene.so
# E: invalid-soname /usr/lib64/libpango_tools.so libpango_tools.so
# E: invalid-soname /usr/lib64/libpango_vars.so libpango_vars.so
# E: invalid-soname /usr/lib64/libpango_video.so libpango_video.so
# E: invalid-soname /usr/lib64/libpango_windowing.so libpango_windowing.so
# E: invalid-soname /usr/lib64/libtinyobj.so libtinyobj.so
@christian-rauch
Copy link
Collaborator

Can you send a PR for this?

@damaestro
Copy link
Contributor Author

#930 is the start of what needs to change. I haven't figured out the pybind11 one yet. Any thoughts?

@damaestro
Copy link
Contributor Author

@christian-rauch okay, the PR is passing testing and all of the Fedora SONAME checks are passing. This should be ready for review.

@christian-rauch
Copy link
Collaborator

Fixed by #930.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants