From 3df789b4cdbf2aba67284a2c763c4fc0aef9162e Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:52:18 +0200 Subject: [PATCH 1/5] fix typos gen_venv.py --- src/cmake_utils/gen_venv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmake_utils/gen_venv.py b/src/cmake_utils/gen_venv.py index 1e7c434..f17e5c7 100755 --- a/src/cmake_utils/gen_venv.py +++ b/src/cmake_utils/gen_venv.py @@ -15,7 +15,7 @@ def filter_interpreter(python: str, entries: List[str]): """ - Filters given list of entries by interpreter prefix. + Filters are given a list of entries by interpreter prefix. Example: filter_interpreter('prefix0', ['a', 'b', 'prefix0:c' ,'prefix1:d']) == \ ['a', 'b', 'c'] From 0c2ddb0427cc1fc15501fa9a325401e66c035ca6 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:52:55 +0200 Subject: [PATCH 2/5] fix typos pip_rules.cmake --- src/cmake_utils/pip_rules.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmake_utils/pip_rules.cmake b/src/cmake_utils/pip_rules.cmake index 3b5064f..c01cfd7 100644 --- a/src/cmake_utils/pip_rules.cmake +++ b/src/cmake_utils/pip_rules.cmake @@ -1,4 +1,4 @@ -# Note: STAMP_FILE is a dummy output file for a target that holds all of the reqeuired file level +# Note: STAMP_FILE is a dummy output file for a target that holds all of the required file level # dependencies of the target. If you have a custom command that needs a dependency target to run # before, it should depend on the target and the stamp file. From 32846c878469b37fd764b825ed01d0b221abe2be Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:54:23 +0200 Subject: [PATCH 3/5] fix typos python_rules.cmake --- src/cmake_utils/python_rules.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmake_utils/python_rules.cmake b/src/cmake_utils/python_rules.cmake index d4283fa..d1eae9a 100644 --- a/src/cmake_utils/python_rules.cmake +++ b/src/cmake_utils/python_rules.cmake @@ -1,4 +1,4 @@ -# CACHE INTERNAL makes the variables definitions available in every scope. +# CACHE INTERNAL makes the definitions of the variables available in every scope. set(GEN_PY_LIB_EXECUTABLE ${CMAKE_CURRENT_LIST_DIR}/gen_py_lib.py CACHE INTERNAL "") set(GEN_VENV_EXECUTABLE ${CMAKE_CURRENT_LIST_DIR}/gen_venv.py CACHE INTERNAL "") set(GEN_PYTHON_EXE_EXECUTABLE ${CMAKE_CURRENT_LIST_DIR}/gen_python_exe.py CACHE INTERNAL "") @@ -125,7 +125,7 @@ endfunction() # Creates a virtual environment target. # Usage: python_venv(venv_name PYTHON ${PYTHON_COMMAND} LIBS lib0 lib1 ...) # Target properties: -# VENV_PYTHON: Full path to the vritual environment python executable. +# VENV_PYTHON: Full path to the virtual environment python executable. # STAMP_FILE: when this file is generated, the virtual environment is ready to use. function(python_venv VENV_NAME) # Parse arguments. From 341b980895ce2b356433d470dafa2c885a8ff0e5 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:55:45 +0200 Subject: [PATCH 4/5] fix typos cairo_cmake_rules.cmake --- src/starkware/cairo/lang/cairo_cmake_rules.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/starkware/cairo/lang/cairo_cmake_rules.cmake b/src/starkware/cairo/lang/cairo_cmake_rules.cmake index 7ac1a29..793504f 100644 --- a/src/starkware/cairo/lang/cairo_cmake_rules.cmake +++ b/src/starkware/cairo/lang/cairo_cmake_rules.cmake @@ -5,7 +5,7 @@ function(cairo_compile_base TARGET_NAME COMPILER_EXE COMPILED_PROGRAM_NAME SOURC # Choose a file name for the Cairo dependencies of the compiled file. set(COMPILE_DEPENDENCY_FILE "${CMAKE_CURRENT_BINARY_DIR}/${TARGET_NAME}_compile_dependencies.cmake") - # If this is the first build, create an empty dependency file (this file will be overriden when + # If this is the first build, create an empty dependency file (this file will be overridden when # cairo-compile is executed with the actual dependencies, using the --cairo_dependencies flag). if(NOT EXISTS ${COMPILE_DEPENDENCY_FILE}) file(WRITE ${COMPILE_DEPENDENCY_FILE} "") @@ -60,7 +60,7 @@ function(cairo_compile_run TARGET_NAME FILENAME STEPS ARTIFACTS COMPILE_FLAGS RU # Choose a file name for the python dependencies of cairo-run. set(RUN_DEPENDENCY_FILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}_run_dependencies.cmake") - # If this is the first build, create an empty dependency file (this file will be overriden when + # If this is the first build, create an empty dependency file (this file will be overridden when # cairo-run is executed with the actual dependencies, using the --python_dependencies flag). if(NOT EXISTS ${RUN_DEPENDENCY_FILE}) file(WRITE ${RUN_DEPENDENCY_FILE} "") From 3c53680b1e37071acd002bd9f8112d71c810eacb Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:59:42 +0200 Subject: [PATCH 5/5] fix typos ProxySupport.sol --- src/starkware/solidity/interfaces/ProxySupport.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/starkware/solidity/interfaces/ProxySupport.sol b/src/starkware/solidity/interfaces/ProxySupport.sol index a2d049a..3004978 100644 --- a/src/starkware/solidity/interfaces/ProxySupport.sol +++ b/src/starkware/solidity/interfaces/ProxySupport.sol @@ -17,7 +17,7 @@ import "./ContractInitializer.sol"; abstract contract ProxySupport is Governance, BlockDirectCall, ContractInitializer { using Addresses for address; - // The two function below (isFrozen & initialize) needed to bind to the Proxy. + // The two function below (isFrozen & initialize) are needed to bind to the Proxy. function isFrozen() external view virtual returns (bool) { return false; } @@ -29,7 +29,7 @@ abstract contract ProxySupport is Governance, BlockDirectCall, ContractInitializ 1. This function cannot be called directly on the deployed contract, but only via delegate call. 2. If an EIC is provided - init is passed onto EIC and the standard init flow is skipped. - This true for both first intialization or a later one. + This is true for both first initialization or a later one. 3. The data passed to this function is as follows: [sub_contracts addresses, eic address, initData].