Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging inconsistency. #19

Open
Pheotis opened this issue Jun 4, 2024 · 1 comment
Open

Logging inconsistency. #19

Pheotis opened this issue Jun 4, 2024 · 1 comment
Labels
enhancement A suggested addition to this project

Comments

@Pheotis
Copy link
Contributor

Pheotis commented Jun 4, 2024

This module has a logging config section.
None of the other modules have such a section.

Either:

  1. All modules should use whatever logging level is specified in the core, and this section should be removed from SGC
  2. All modules should have their own logging toggle, and the logging section should be added to all other modules.
@Pheotis Pheotis added the enhancement A suggested addition to this project label Jun 4, 2024
@Thorinwasher
Copy link
Contributor

I think 2, I do not like 1. at all.

So this is really an issue in the other modules. But why do they need to be exactly consistent here, this seems like a very low priority issue to the very least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A suggested addition to this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Thorinwasher @Pheotis