Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: counts should be integers #256

Open
pbailis opened this issue Mar 1, 2018 · 1 comment
Open

SQL: counts should be integers #256

pbailis opened this issue Mar 1, 2018 · 1 comment

Comments

@pbailis
Copy link
Member

pbailis commented Mar 1, 2018

Output for counts in SQL (outlier_count, total_count) are formatted as floats, but counts should always be integer-valued (I think).

e.g.,

macrobase-sql> SELECT * FROM DIFF(SPLIT (SELECT *, percentile(battery_drain) AS percentile from mobile) WHERE percentile > .99) ON *;
67156 [main] INFO  QueryEngine  - Using user_id, state, hw_make, firmware_version, app_version as candidate attributes for explanation
67265 [main] INFO  APLSummarizer  - Encoded in: 109 ms
67265 [main] INFO  APLSummarizer  - Encoded Categories: 2
67299 [main] INFO  APLSummarizer  - Number of results: 2
2 rows

----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|    app_version     |      user_id       |      hw_make       |       state        |  firmware_version  |      support       |    global_ratio    |   outlier_count    |    total_count     |
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|        v50         |         -          |         -          |         -          |         -          |      .873185       |     89.883198      |       902.0        |       1003.0       |
|         -          |         -          |       Emdoor       |         -          |         -          |      .873185       |     89.883198      |       902.0        |       1003.0       |
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
@pbailis
Copy link
Member Author

pbailis commented Mar 1, 2018

Related: Is there a reason why we have outlier_count versus a more generic population_A_cnt and population_B_cnt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant