diff --git a/internal/cmd/secrets-manager/instance/create/create_test.go b/internal/cmd/secrets-manager/instance/create/create_test.go index 936ec21b..cd8df3d1 100644 --- a/internal/cmd/secrets-manager/instance/create/create_test.go +++ b/internal/cmd/secrets-manager/instance/create/create_test.go @@ -95,6 +95,7 @@ func TestParseInput(t *testing.T) { flagValues: map[string]string{ projectIdFlag: testProjectId, instanceNameFlag: "", + aclFlag: "", }, isValid: true, expectedModel: &inputModel{ @@ -102,6 +103,7 @@ func TestParseInput(t *testing.T) { ProjectId: testProjectId, }, InstanceName: utils.Ptr(""), + Acls: &[]string{}, }, }, { @@ -121,13 +123,6 @@ func TestParseInput(t *testing.T) { model.Acls = nil }), }, - { - description: "acl empty", - flagValues: fixtureFlagValues(func(flagValues map[string]string) { - flagValues[aclFlag] = "" - }), - isValid: false, - }, { description: "repeated acl flags", flagValues: fixtureFlagValues(), diff --git a/internal/cmd/secrets-manager/instance/update/update_test.go b/internal/cmd/secrets-manager/instance/update/update_test.go index fdaf807c..ee62ce0b 100644 --- a/internal/cmd/secrets-manager/instance/update/update_test.go +++ b/internal/cmd/secrets-manager/instance/update/update_test.go @@ -127,7 +127,10 @@ func TestParseInput(t *testing.T) { projectIdFlag: testProjectId, aclFlag: "", }, - isValid: false, + isValid: true, + expectedModel: fixtureInputModel(func(model *inputModel) { + model.Acls = &[]string{} + }), }, { description: "project id missing",