Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Kubeconfig not written when output format is json #553

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Fix: Kubeconfig not written when output format is json #553

merged 3 commits into from
Jan 10, 2025
+45 −5

Conversation

marceljk
Copy link
Contributor

  • Add flag to disable the writing of kubeconfig

@marceljk
Fix: Kubeconfig doesn't get written when output format is json
4f25d16 
- Add flag to disable the writing of kubeconfig
@marceljk marceljk linked an issue Jan 10, 2025 that may be closed by this pull request
stackit ske kubeconfig create doesn´t create a kubeconfig when the output is json #552
Open
@marceljk marceljk changed the title Fix: Kubeconfig doesn't get written when output format is json Fix: Kubeconfig not written when output format is json Jan 10, 2025
vicentepinto98
vicentepinto98 reviewed Jan 10, 2025
View reviewed changes
internal/cmd/ske/kubeconfig/create/create.go Outdated Show resolved Hide resolved
internal/cmd/ske/kubeconfig/create/create.go Outdated Show resolved Hide resolved
internal/cmd/ske/kubeconfig/create/create.go Outdated Show resolved Hide resolved
@marceljk marceljk merged commit a3a0754 into main Jan 10, 2025
3 checks passed
@marceljk marceljk deleted the 552-stackit-ske-kubeconfig-create-doesn´t-create-a-kubeconfig-when-the-output-is-json branch January 10, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentepinto98 vicentepinto98 vicentepinto98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stackit ske kubeconfig create doesn´t create a kubeconfig when the output is json
2 participants
@marceljk @vicentepinto98