Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase bulk size from 100 -> 500 #115

Open
MatusKysel opened this issue Sep 4, 2024 · 1 comment
Open

Increase bulk size from 100 -> 500 #115

MatusKysel opened this issue Sep 4, 2024 · 1 comment

Comments

@MatusKysel
Copy link
Contributor

Currently have fixed limit of bulk validators https://github.com/ssvlabs/ssv-dkg/blob/unstable/cli/utils/utils.go#L362 set to 100.

For increasing this we should consider changing following values:
https://github.com/ssvlabs/ssv-dkg/blob/unstable/pkgs/initiator/initiator.go#L113
https://github.com/ssvlabs/ssv-dkg/blob/unstable/pkgs/wire/dkg.go#L37

and probably implementing this

// FastSync is a mode where nodes sends pre-emptively responses indicating
	// that the shares they received are good. If a share is invalid, a
	// complaint is still sent as usual. This has two consequences:
	//  - In the event all shares are good, nodes don't need to wait for the
	//  timeout; they can already finish the protocol at the point.
	//  - However, it requires nodes to send more messages on the network. We
	//  pass from a O(f) where f is the number of faults to a O(n^2). Note that
	//  the responses messages are small.
	FastSync [bool](https://pkg.go.dev/builtin#bool)

source https://pkg.go.dev/github.com/drand/kyber/share/dkg

With this flag enabled, we should be able to run the DKG ceremony faster, but it will increase the number of messages on the network.

@RaekwonIII
Copy link
Collaborator

Yes plz 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants