Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja2 v 3.1.0 breaks jinjasql #50

Open
Andrew-Sheridan opened this issue Mar 24, 2022 · 16 comments
Open

Jinja2 v 3.1.0 breaks jinjasql #50

Andrew-Sheridan opened this issue Mar 24, 2022 · 16 comments

Comments

@Andrew-Sheridan
Copy link

Andrew-Sheridan commented Mar 24, 2022

Jinja2 moved deprecated objects to Markupsafe. This is causing 'import jinjasql' to break.

If possible, could you please

  • update the dependencies
  • update the code to use the relocated objects
  • release the changes to PyPi

Thanks

@jameskelly77
Copy link

Same issue here, confirmed that Jinja2==3.0.3 in the pip install will keep it working, but the latest does break the import.

@afgaron
Copy link

afgaron commented Mar 25, 2022

To fix this error in another workflow, I also had to pin markupsafe==2.0.1

@jordantshaw
Copy link

Same issue here. Pinned to Jinja2==3.0.3 for a temporary fix.

@jpy-git
Copy link

jpy-git commented Mar 30, 2022

Looks like the Jinja2 requirement was pinned to <3.0 a couple months back on master

jinjasql/setup.py

Lines 41 to 43 in d1e0d0f

'install_requires': [
'Jinja2>=2.5,<3.0'
],

But there hasn't been a release to get that into PyPI yet

Pinning seems like the solution for now

@ryandavis3
Copy link

Also seeing the same issue.

@adamarla
Copy link

adamarla commented Apr 5, 2022

+1

@conor-james-sheehan
Copy link

Same here. @sripathikrishnan any chance you would be able to create a new release on PyPi? 🙏

@rs-sathya
Copy link

rs-sathya commented May 3, 2022

👍 would like a new release as well, or at least a tag! Thank you!!

@ccompeau
Copy link

ccompeau commented May 5, 2022

+1 👍 new release please!!

@femi-anthony
Copy link

Same here..

@r-nyq
Copy link

r-nyq commented Jul 21, 2022

Are there any plans on releasing a fix for this?

@elpablete
Copy link

Is this project abandoned?

@PandaWhoCodes
Copy link

looks like it @elpablete

@SridharCR
Copy link

We are maintaining a forked version of jinjasql here - https://github.com/pythonutilities/jinjasql

Check this out, we have upgraded the code and its dependencies and so that it can work with the updated Jinja 3.x

@elpablete
Copy link

We are maintaining a forked version of jinjasql here - https://github.com/pythonutilities/jinjasql

Check this out, we have upgraded the code and its dependencies and so that it can work with the updated Jinja 3.x

are you going to publish it on pypi? name change?

@SridharCR
Copy link

@elpablete We have published the above said forked version of jinjasql in PyPi, check it out!

pip install jinjasql2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.