Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Markup from markupsafe #51

Closed

Conversation

jpy-git
Copy link

@jpy-git jpy-git commented Mar 30, 2022

Closes #50 and closes #44.
We should import Markup from markupsafe as per this comment: pallets/jinja#1628 (comment)

Additionally we don't need to add the autoescape extension as it's already included by default as per this comment: pallets/jinja#1627 (comment)

setup.py Show resolved Hide resolved
Copy link

@dan-hook dan-hook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests passed, and I was able to use this branch in my own project.

@rcuza
Copy link

rcuza commented Apr 4, 2022

This fix resolves the dependency issue we are encountering. Will it be released soon?

@adamarla
Copy link

adamarla commented Apr 5, 2022

Echoing the sentiment by @rcuza , could the be released soon. Many thanks!

@Andrew-Sheridan
Copy link

@sripathikrishnan We are curious if you could release this to pypi.org?

Thanks!

@mambon2
Copy link

mambon2 commented Apr 21, 2022

Any idea when this PR will be merged and released?

@jpy-git
Copy link
Author

jpy-git commented Apr 27, 2022

Seems like the project is inactive

@jpy-git jpy-git closed this Apr 27, 2022
@jpy-git jpy-git deleted the import_markup_from_markupsafe branch April 27, 2022 11:09
@mambon2
Copy link

mambon2 commented Apr 27, 2022

What is a good replacement for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants