Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "api.js" into its own place #29

Open
dpordomingo opened this issue May 16, 2018 · 0 comments
Open

Move "api.js" into its own place #29

dpordomingo opened this issue May 16, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@dpordomingo
Copy link
Contributor

from #16 (comment)

We could move frontend/src/api.js into its own place as done in CAT for example.

I see two reasons:

  • first one is kindof opinionated: imo the root dir should be populated with as fewer things as possible because it helps to understand better the structure of the code.
  • second one is generic: now we have in this file the logic (copy-pasted from cat) to connect with the API (business agnostic), and also the "repository-like" code (business related). Splitting both parts properly, and moving business agnostic to a service, and the business logic to a repository would help us to reuse and test better.
@dpordomingo dpordomingo added the enhancement New feature or request label May 16, 2018
@dpordomingo dpordomingo mentioned this issue May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant