Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add provide experimental support for Google Gemini #67 #68

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

shanehuntley
Copy link
Contributor

Basic provider support for Google Gemini models.

Passes local and integration tests. Requires GOOGLE_API_KEY to be set for use but works with Gemini API Free Tier.

Example Goose configuration:

default:
provider: google
processor: gemini-1.5-pro
accelerator: gemini-1.5-flash
moderator: passive
toolkits:

  • name: developer
    requires: {}

Fixes #67

tests/test_integration.py Outdated Show resolved Hide resolved
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool start. Is there any way you can add VCR tests such as exist in openai? If not, I can I guess sign up for access and fill them later.

Also, did you manage to try vision? I didn't look up if the free tier includes a vision capable model. If so, give a whirl in test_integration.py!

Finally, do we need an entry in pyproject.toml under here?

[project.entry-points."exchange.provider"]

tests/test_integration.py Outdated Show resolved Hide resolved
@shanehuntley
Copy link
Contributor Author

I haven't looked at VCR tests or the vision aspects yet. Both gemini flash and pro do support vision.

@codefromthecrypt
Copy link
Contributor

Both gemini flash and pro do support vision.

quick try is to add a tuple to test_integration_vision.py and see if it works?

Copy link
Collaborator

@baxen baxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Agree we should pursue VCR and vision tests but happy for those to be in another PR, since this looks to be working for the core use cases

@adhintz adhintz merged commit 24a9e8b into square:main Oct 1, 2024
5 checks passed
lifeizhou-ap added a commit that referenced this pull request Oct 2, 2024
* main:
  feat: Add provide experimental support for Google Gemini #67 (#68)
codefromthecrypt pushed a commit to codefromthecrypt/exchange that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Google Gemini API as a Provider
4 participants