Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should issuedAt for SiweMessage be a required member variable? #211

Open
derekpierre opened this issue Aug 27, 2024 · 0 comments
Open

Should issuedAt for SiweMessage be a required member variable? #211

derekpierre opened this issue Aug 27, 2024 · 0 comments

Comments

@derekpierre
Copy link

According to the EIP4361 spec, issuedAt should be required - https://docs.login.xyz/general-information/siwe-overview/eip-4361#specification.

However, the value of the issuedAt member variable is optional - https://github.com/spruceid/siwe/blob/main/packages/siwe/lib/client.ts#L49.

This forces an undefined check before use. Is there a way to not have that be the case.

(caveat: Typescript is not my strong suit 😅 )
@derekpierre derekpierre changed the title Should issuedAt for SiweMessage be a required member variable Should issuedAt for SiweMessage be a required member variable? Aug 27, 2024
@derekpierre derekpierre mentioned this issue Aug 27, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derekpierre