Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid opts check is looking at the wrong array #202

Open
mihoward21 opened this issue May 20, 2024 · 1 comment
Open

invalid opts check is looking at the wrong array #202

mihoward21 opened this issue May 20, 2024 · 1 comment

Comments

@mihoward21
Copy link

At this line: https://github.com/spruceid/siwe/blob/main/packages/siwe/lib/client.ts#L242

it should be checking invalidOpts.length, not invalidParams.length.
@sbihel
Copy link
Member

sbihel commented May 23, 2024

You are absolutely correct. Would you be interested in raising a PR for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihoward21 @sbihel