Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Halt backfill improvements #405

Open
fabriziodemaria opened this issue Feb 27, 2018 · 2 comments
Open

Halt backfill improvements #405

fabriziodemaria opened this issue Feb 27, 2018 · 2 comments

Comments

@fabriziodemaria
Copy link
Member

Halting a backfill causes all backfill's instances to be halted. Failing to halt even a single instance will stop the halting procedure giving to the user a message for half-success (backfill is halted, but some instances are still running). We should retry to halt an instance in case of error.

@ulzha
Copy link
Contributor

ulzha commented Feb 28, 2018

Yeah, backfill shouldn't change status to halted though unless all the instances were halted. The choice to retry or not perhaps should be left to the client, otherwise we can end up retrying for arbitrarily long time...

@honnix
Copy link
Member

honnix commented Aug 7, 2019

Failing to halt even a single instance will stop the halting procedure

This is not anymore the case. Styx will try to halt all instances and return an error to the client if failed to halt any of the instances.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants