Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add rate limiter handler to spotify client #2264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

unsync
Copy link

@unsync unsync commented Dec 21, 2024

add rate limiter handler to spotify client

Description

I was getting into constant 429 errors while syncing any playlist, even when rotating with several spotify apps.

This has been tested locally, it should allow to respect spotify apis rate limiting headers and backoff until allowed, solving most of the 429 errors.

⚠️ disclamer: i gpt-ed this, when i was trying to find a solution for this issue. I'm not fluent in python, so i can try to add tests if needed but if someone can help on this PR to finish it if accepted i would appreciate it 🙏

How Has This Been Tested?

Only locally, by running a sync over several playlists

Screenshots (if appropriate)

Capture d’écran 2024-12-21 à 17 03 51

Types of Changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant