Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Framework: Integrate Azure SDK for Go for Azure Blob Client #1378

Open
locmai opened this issue Sep 25, 2024 · 2 comments
Open

App Framework: Integrate Azure SDK for Go for Azure Blob Client #1378

locmai opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
2.7 app framework New App Framework

Comments

@locmai
Copy link
Contributor

locmai commented Sep 25, 2024

Please select the type of request

Enhancement

Tell us more

Describe the request

  • The current implementation of the pkg/splunk/client/azureblobclient.go is based on the Go net/http module, requiring manual construction of all requests instead of using the official Azure SDK for Go. We have observed a couple of issues related to the authentication requests, see Additional context section.
  • Similar to what we have with AWS S3 client in pkg/splunk/client/awss3client.go

Expected behavior

Splunk setup on K8S

  • Simple Splunk on K8S in Azure wirh aadpodbinding and App Framework with Azure blob storage

Reproduction/Testing steps

  • N/A

K8s environment

  • Azure Kubernetes Service

Proposed changes(optional)

Additional context

We got connect: cannot assign requested address error message intermittently:

AzureBlob:GetAppsList	Failed to get http request authenticated	{"controller": "clustermanager", "controllerGroup": "enterprise.splunk.com", "controllerKind": "ClusterManager", "ClusterManager": {"name":"cm","namespace":"splunk"}, "namespace": "splunk", "name": "cm", "reconcileID": "c488e81f-1f94-4e8b-90f3-6cb32809c5dd", "Endpoint": "https://<redacted>.blob.core.windows.net/", "Bucket": "splunk-apps", "Prefix": "indexers/", "error": "Get \"http://169.254.169.254/metadata/identity/oauth2/token?api-version=2021-10-01&resource=https%3A%2F%2Fstorage.azure.com%2F\": dial tcp 169.254.169.254:80: connect: cannot assign requested address"}

And #1356

@locmai locmai added the app framework New App Framework label Sep 25, 2024
@locmai
Copy link
Contributor Author

locmai commented Sep 25, 2024

I'd be happy to work on this and open a PR. Just want to confirm if this is on the right track.

@vivekr-splunk
Copy link
Collaborator

currently we are working on this change, hoping to release this with upcoming release. we will update you once we are done with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 app framework New App Framework
Projects
None yet
Development

No branches or pull requests

3 participants