Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COC and CLA jobs overrides each other #59

Open
vtsvetkov-splunk opened this issue Apr 10, 2024 · 2 comments
Open

COC and CLA jobs overrides each other #59

vtsvetkov-splunk opened this issue Apr 10, 2024 · 2 comments

Comments

@vtsvetkov-splunk
Copy link

The issue

The first job asks about CLA, then another job, COC, runs and overrides the comment from the first one. The end user sees the latest message about COC and has no idea of that CLA also has to be signed.

It seems like a bug (or feature) of contributor-assistant/github-action:
https://github.com/contributor-assistant/github-action/blob/master/src/pullrequest/pullRequestComment.ts#L58
It looks for the first occurance of comment with CLA Assistant Lite bot and edits that comment. This github action is not supposed to work as jobs simultaneously.

Solutions

Possible solution 1: merge CLA and COC into a single job.
Possible solution 2: find another alternative for contributor-assistant/github-action

@artemrys
Copy link
Member

It looks like a regression in the CLA tool itself, I can clearly remember when it used to post 2 messages.

@artemrys
Copy link
Member

@vtsvetkov-splunk do you think we can figure out how to fix it for them and potentially propose a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants