Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: mu_s scaling of LLG equation in effective field terms #363

Closed
GPMueller opened this issue Dec 6, 2017 · 4 comments
Closed

Core: mu_s scaling of LLG equation in effective field terms #363

GPMueller opened this issue Dec 6, 2017 · 4 comments

Comments

@GPMueller
Copy link
Member

GPMueller commented Dec 6, 2017

It seems the implementation is missing a factor 1/mu_s in the LLG equation's effective field terms:
screen shot 2017-12-06 at 21 50 54

@GPMueller
Copy link
Member Author

GPMueller commented Jan 3, 2018

It may be a good idea to first move the mu_s factors from the Hamiltonians to the Geometry (see #364).

@GPMueller GPMueller changed the title Core: mu_s scaling of LLG equation Core: mu_s scaling of LLG equation in effective field terms Jan 3, 2018
@GPMueller
Copy link
Member Author

#364 has been implemented with 3e4df99, so this issue could be implemented now. Note the relation to #143: it would definitely make sense to have a list of mu_s values for all spins, as this would greatly ease the implementation of scaling for LLG.

@GPMueller
Copy link
Member Author

With 978682a, mu_s and cell_mu_s are now distinguished. The former can now be used to correctly scale LLG. Might be worth adding a function void scale(vectorfield & vf, const scalarfield & sf); next to the already existing void scale(vectorfield & vf, const scalar & sc);

@GPMueller
Copy link
Member Author

GPMueller commented Nov 6, 2018

Fixed with 537b87c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant