Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bare user/repo slugs in repository input field #67

Open
jcbhmr opened this issue Apr 24, 2023 · 6 comments
Open

Support bare user/repo slugs in repository input field #67

jcbhmr opened this issue Apr 24, 2023 · 6 comments

Comments

@jcbhmr
Copy link
Contributor

jcbhmr commented Apr 24, 2023

No description provided.

@jcbhmr jcbhmr mentioned this issue Apr 24, 2023
4 tasks
@jcbhmr
Copy link
Contributor Author

jcbhmr commented Apr 24, 2023

@spenserblack are you ok with splitting into repository: and github-server-url: options? actions/checkout does this. https://github.com/actions/checkout#usage

image
image

@spenserblack
Copy link
Owner

are you ok with splitting into repository: and github-server-url: options?

Yes, that's preferable 👍
Many inputs are missing from this action not because of a preference to omit them, but because they weren't required for a minimally viable release.

@spenserblack
Copy link
Owner

So the idea here is that it would clone a bare repository and set --work-tree to the wiki directory?

@jcbhmr
Copy link
Contributor Author

jcbhmr commented Apr 24, 2023

So the idea here is that it would clone a bare repository and set --work-tree to the wiki directory?

it could! i hadnt even thought of that.

the reason i brought up the split repository: and github-server-url: thing was because right now if we wanted to allow:

repository: jcbhmr/my-mega-project
repository: github.com/jcbhmr/my-mega-project
repository: github-enterprise.com/jcbhmr/my-mega-project
repository: http://gh.enterprise.com/jcbhmr/my-mega-project
repository: https://github.enterprise.com/jcbhmr/my-mega-project

as all valid, we'd need to do some fancy url magic and parsing and complex madness. 😵 its easier and also happens to be convention 😊 that its split into repository: user/repo and github-server-url: https://github-enterprise.com as separate inputs. and this idea just made it easy 🤷‍♀️

to recap, i hope to make it so that the inputs are something like:

# names from https://github.com/actions/checkout#usage
repository: jcbhmr/my-mega-project
github-server-url: https://github.enterprise.com
path: .
token: ${{ secrets.MEGA_PROJECT_PAT }}
# names and stuff inspired by https://github.com/stefanzweifel/git-auto-commit-action but with kebab-case instead of snake_case
commit-message: Hello world ${{ github.sha }}
commit-author: GitHub Actions <[email protected]>
commit-user-name: github-actions[bot]
commit-user-email: 41898282+github-actions[bot]@users.noreply.github.com
# standard name from https://github.com/search?q=org%3Aactions+dry-run+language%3AYAML&type=code&l=YAML
dry-run: true

thats my dream option set lmao 😅

@spenserblack
Copy link
Owner

Oh, got it, by "bare" you meant "domain prefix removed"? I was thinking of "bare" as git terminology 😆

That YAML code block looks perfect to me 👍

@jcbhmr
Copy link
Contributor Author

jcbhmr commented May 16, 2023

speaking of dream options sets, here's my ideal github wiki action. well, pretty ideal: https://github.com/Andrew-Chen-Wang/github-wiki-action/tree/jcbhmr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants